static query hooks fixes: modelOptions in DelegateOperation should forward to the one from the delegated operation, resolve modelOptions.old properly for graph operations
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkenhawk
force-pushed
the
fix-delegate-model-options-local
branch
from
e70f401 to
6b67efc
Compare
the delegated operation - to make `modelOptions` always available in static query hooks, also when using upsertGraph(AndFetch) and patchAndFetchById - also fix the query builder being executed on the model built from a graph instead of the source(current) model - the modelOptions.old should contain the old values read from db, not the new ones from the graph.
falkenhawk
force-pushed
the
fix-delegate-model-options-local
branch
from
8081721 to
ad9c72c
Compare
|
also submitted upstream: Vincit#2730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modelOptionsinDelegateOperationshould forward to the one from the delegated operationmodelOptionsalways available in static query hooks, also when using upsertGraph(AndFetch) and patchAndFetchByIdmodelOptions.oldshould contain the old values read from db, not the new ones from the graph.